Remove added parent directory from certs path #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liampauling Seems that coverage has declined by 0.0002% and thus failing. Could you take a look at the PR and let me know what you think? |
liampauling
reviewed
Mar 6, 2020
| @@ -156,9 +156,8 @@ def cert(self) -> list: | |||
| return self.cert_files | |||
|
|
|||
| certs = self.certs or "/certs/" | |||
There was a problem hiding this comment.
I am thinking that maybe we should update the class initialisation as well and remove this line and replace with in the init:
certs: str = os.path.join(“certs”)
| @@ -199,7 +199,7 @@ def test_client_certs_mocked(self, mock_listdir): | |||
| [".DS_Store", "client-2048.crt", "client-2048.key"] | |||
| ) | |||
There was a problem hiding this comment.
It would be good to add another test that confirms that certs=“/tmp” is correct
Yeah don’t worry about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #279